From: Felipe Contreras Date: Wed, 06 Jun 2012 12:22:59 GMT Subject: Re: What's cooking in git.git (Jun 2012, #01; Sun, 3) Message-ID: In-Reply-To: <7vr4twudqm.fsf@alter.siamese.dyndns.org> On Mon, Jun 4, 2012 at 2:23 AM, Junio C Hamano wrote: > * fc/git-prompt-script (2012-05-22) 5 commits >  - completion: split __git_ps1 into a separate script >  - completion: remove executable mode >  - Merge branch 'fc/git-complete-helper' into fc/git-prompt-script >  - tests: add tests for the bash prompt functions in the completion script >  - tests: move code to run tests under bash into a helper library >  (this branch is tangled with sg/bash-prompt.) > > The last remaining sticking point is what to do with the duplicated shell > function. What is the problem with leaving it as it is; having it as a duplicate function. It's not a *huge* maintenance burden, and it's a big problem if the functions diverge. I still plan to add a native helper for this, but I don't see what that would block these patches. -- Felipe Contreras