From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Fri, 13 Apr 2012 10:34:46 GMT
Subject: Re: [PATCH v2] tests: add initial bash completion tests
Message-ID: <CAMP44s0_WQNpkVi0yMfaDgzBaUWOhRiS-2qxLtCHFzx71yKrSw@mail.gmail.com>
In-Reply-To: <20120413091236.GC2164@goldbirke>

2012/4/13 SZEDER Gábor <szeder@ira.uka.de>:

>> +test_expect_success 'basic' '
>> +     run_completion "git \"\"" &&
>> +     # built-in
>> +     grep -q "^add \$" out &&
>> +     # script
>> +     grep -q "^filter-branch \$" out &&
>> +     # plumbing
>> +     ! grep -q "^ls-files \$" out
>
> The && is missing here at the end of the line.

Right.

>> +     run_completion "git f" &&
>> +     ! grep -q -v "^f" out
>
> grep is not a git command, so I'm not sure, but shouldn't these use
> 'test_must_fail grep' instead of '! grep'?

I'm not sure. Junio has already queued this, maybe you should send a
patch on top of that.

Cheers.

-- 
Felipe Contreras