From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sun, 15 Apr 2012 19:42:56 GMT
Subject: Re: [PATCH v3 0/5] completion: trivial cleanups and fixes
Message-ID: <CAMP44s0EPgS8MX4B7Wc4XW+S+JeJiuo63Rv-KiP=q0YTMbtd7g@mail.gmail.com>
In-Reply-To: <20120415132002.GB2544@burratino>

On Sun, Apr 15, 2012 at 4:20 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Felipe Contreras wrote:

>>   completion: trivial simplification
>
> Improves consistency.  The changelog line isn't precise enough to
> remind me which change is being mentioned when reading it in the
> shortlog, so I guess I'd prefer something like
>
>        completion: simplify by using $prev variable

OK.

>>   completion: add missing general options
>
> Likewise, a subject line like the following would work better for
> me.
>
>        completion: --info-path and --no-replace-objects options for git

That's too long, and I think it's less understandable: for git? Of
course it's for git, for what else could it be? :) maybe s/options for
git/general options/, but it's still too long.

I'll leave it like that, anybody else can change it if they wish.

Cheers.

-- 
Felipe Contreras