From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sat, 24 Nov 2012 03:28:39 GMT
Subject: Re: [PATCH v6 p2 1/9] transport-helper: update remote helper namespace
Message-ID: <CAMP44s070w14K5ODv=5s2f0agV1aVn3FSBmXMmM6M2UqPd7Sdw@mail.gmail.com>
In-Reply-To: <1353727520-26039-2-git-send-email-felipe.contreras@gmail.com>

On Sat, Nov 24, 2012 at 4:25 AM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:

> @@ -673,11 +675,23 @@ static void push_update_refs_status(struct helper_data *data,
>         struct strbuf buf = STRBUF_INIT;
>         struct ref *ref = remote_refs;
>         for (;;) {
> +               char *private;
> +
>                 recvline(data, &buf);
>                 if (!buf.len)
>                         break;
>
> -               push_update_ref_status(&buf, &ref, remote_refs);
> +               if (push_update_ref_status(&buf, &ref, remote_refs))
> +                       continue;
> +
> +               if (!data->refspecs)
> +                       continue;
> +
> +               /* propagate back the update to the remote namespace */
> +               private = apply_refspecs(data->refspecs, data->refspec_nr, ref->name);
> +               if (!private)
> +                       continue;
> +               update_ref("update by helper", private, ref->new_sha1, NULL, 0, 0);

free(private); I guess


-- 
Felipe Contreras