From: Hitoshi Mitake <h.mitake@gmail.com>
Date: Fri, 23 Mar 2012 17:15:16 GMT
Subject: Re: [PATCH v0 0/2] git-less: a specialized pager for git-log
Message-ID: <CAMO-S2gUaek83ACtLLBsLFYBpHuj=ePZRPzEPav+uP6igjN7oA@mail.gmail.com>
In-Reply-To: <7v1uokxxzh.fsf@alter.siamese.dyndns.org>

On Fri, Mar 23, 2012 at 04:00, Junio C Hamano <gitster@pobox.com> wrote:
> Hitoshi Mitake <h.mitake@gmail.com> writes:
>
>> If the pager can recognize the end of each commit, more confortable viewing of
>> git-log's output will be possible.
>
> I think people just use "/^commit .*<RET>" once and then nagivate with "n"
> (and to change direction, "?<RET>") for this.

Yes, but less cannot search regex with specified range of text
(in this case, from the beginning to the end of the commit).

>
>> For implementing this feature, I had to make modification of git-log
>
> I do not think the change to "log" is necessary nor worth it.  If the
> pager is so specialized to be tied to git, it should learn to recognize
> the output from "git", namely, "git log" and "git log -p" would never have
> a line that begins with "^commit " that is not the beginning of one record
> for a commit.

This rule is useful for detection of each commit from pager. I didn't
have to modify git-log... With this rule, the pager can be independent from
the tree of git, thanks!

>
> If you are not comfortable using "less", perhaps a program like "tig" that
> is very specialized for working with git might help you better.
>

Thanks for your information. I didn't know about tig. I'd like to test it or
modify my pager for more comfortable git-log viewing.

Thanks for your feedback,
-- 
Hitoshi Mitake
h.mitake@gmail.com