From: Alex Henrie <alexhenrie24@gmail.com>
Date: Sun, 09 May 2021 23:06:49 GMT
Subject: Re: [PATCH] graph: improve grammar of "invalid color" error message
Message-ID: <CAMMLpeRFjHNCUqzRhJZDuUA_CxsNvR-gn4-Mb6kmNQSZ4L8y6g@mail.gmail.com>
In-Reply-To: <CAPig+cTm7rW7V2DasW2XTArHAY_91rxxm5QaF31U8rB1ZLXOvQ@mail.gmail.com>

On Sun, May 9, 2021 at 4:03 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
>
> On Sun, May 9, 2021 at 5:23 PM Alex Henrie <alexhenrie24@gmail.com> wrote:
> > Without the "d", it sounds like a command, not an error, and is liable
> > to be translated incorrectly.
> >
> > Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> > ---
> > diff --git a/graph.c b/graph.c
> > @@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)
> > -                       warning(_("ignore invalid color '%.*s' in log.graphColors"),
> > +                       warning(_("ignored invalid color '%.*s' in log.graphColors"),
>
> Another possibility: "ignoring invalid color ... in ..."
>
> Even better: "invalid color ... in ..."

Any of those would be fine. I don't have a strong opinion.

-Alex