From: Prathamesh Chavan <pc44800@gmail.com>
Date: Sat, 05 Aug 2017 18:03:09 GMT
Subject: Re: [GSoC][PATCH 08/13] submodule: port submodule subcommand 'summary' from shell to C
Message-ID: <CAME+mvXGK2zeCHgayS8=ti75CBY6Vp7Qkq+mgvWStQ+vEyLtPg@mail.gmail.com>
In-Reply-To: <CAP8UFD2oqdaQqVwuGqqj9OOnm5Pyufpck=rod0UFQEWrROJsXQ@mail.gmail.com>

On Sat, Aug 5, 2017 at 10:25 PM, Christian Couder
<christian.couder@gmail.com> wrote:
> On Sat, Aug 5, 2017 at 12:28 PM, Prathamesh Chavan <pc44800@gmail.com> wrote:
>> On Tue, Aug 1, 2017 at 4:57 AM, Christian Couder
>> <christian.couder@gmail.com> wrote:
>>> On Mon, Jul 31, 2017 at 10:56 PM, Prathamesh Chavan <pc44800@gmail.com> wrote:
>>>
>> We can avoid it to behave same for "" and NULL, by checking if diff_cmd
>> is "cmd_diff_files", since its value is set NULL by this case.
>>
>> ret = compute_summary_module_list(strcmp(diff_cmd, "diff-files") ?
>> NULL: sb.buf, &info);
>> strbuf_release(&sb);
>
> It looks error prone, more fagile and less efficient to me.

I think by using enum { DIFF_INDEX, DIFF_FILES },
we can avoid using strcmp() here, and make it more efficient
not only here but also in other parts of the code, since
all such steps involving strcmp could be removed.

Thanks,
Prathamesh Chavan