From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Tue, 31 Jul 2018 00:17:11 GMT
Subject: Re: [PATCH] tests: make use of the test_must_be_empty function
Message-ID: <CAM0VKjmgx1v9n90qc9rd2uY0Ki51UJb2DvpbP3_mUj59E1NABA@mail.gmail.com>
In-Reply-To: <20180727174811.27360-1-avarab@gmail.com>

On Fri, Jul 27, 2018 at 7:48 PM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
>
> Change various tests that use an idiom of the form:
>
>     >expect &&
>     test_cmp expect actual
>
> To instead use:
>
>     test_must_be_empty actual

Thanks for working on this.

> The test_must_be_empty() wrapper was introduced in ca8d148daf ("test:
> test_must_be_empty helper", 2013-06-09). Many of these tests have been
> added after that time. This was mostly found with, and manually pruned
> from:
>
>     git grep '^\s+>.*expect.* &&$' t

This command doesn't output anything as it is, it should be 'git grep
-E ...'.

Furthermore, it doesn't catch the cases when the empty expected file
is written as ': > expect'.  I see that you noticed and converted a
few of these, too, but running

  git grep ': >.*exp.*&&' t/

turns up some more.