From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Fri, 26 Jan 2018 19:23:24 GMT
Subject: Re: [PATCH 10/10] t: make 'test_i18ngrep' more informative on failure
Message-ID: <CAM0VKj=Qsbkog+rj94bZOk=G-XBsXAqQnRUo4eCXQq2LKjre-w@mail.gmail.com>
In-Reply-To: <20180126185007.GG27618@sigill.intra.peff.net>

On Fri, Jan 26, 2018 at 7:50 PM, Jeff King <peff@peff.net> wrote:
> On Fri, Jan 26, 2018 at 01:37:08PM +0100, SZEDER Gábor wrote:
>
>> When 'test_i18ngrep' can't find the expected pattern, it exits
>> completely silently; when its negated form does find the pattern that
>> shouldn't be there, it prints the matching line(s) but otherwise exits
>> without any error message.  This leaves the developer puzzled about
>> what could have gone wrong.
>>
>> Make 'test_i18ngrep' more informative on failure by printing an error
>> message including the invoked 'grep' command and the contents of the
>> file it had to scan through.
>
> I think this is an improvement. You can also use "-x" to get a better
> sense of exactly which command failed,

Yeah, I know...  but I have some issues with running tests with '-x'; I
suspect PEBKAC, but haven't yet got around to investigate.