From: Jonathan Lebon <jonathan.lebon@gmail.com>
Date: Tue, 03 Nov 2015 03:12:13 GMT
Subject: Re: [PATCH 1/4] diff-highlight: add `less -r` to cmd in README
Message-ID: <CAM0PgJ6XZmtuSXPq77V_TSoj_b=KhU2AFxmUgbkoE_f9e8Prmw@mail.gmail.com>
In-Reply-To: <xmqq7flzerda.fsf@gitster.mtv.corp.google.com>

On Mon, Nov 2, 2015 at 9:41 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
> Jonathan Lebon <jonathan.lebon@gmail.com> writes:
>
> > As it is, the suggested command for trying out diff-highlight will just
> > dump the whole git log output to the terminal. Let's pipe it through
> > `less` so users aren't surprised on the first try.
>
> That justifies the "less" part but not your choice of "-r".
>
> I am assuming that you are telling "less" not to show the ANSI
> "color" escape sequences using the caret notation with "-r", which
> is a very natural and sensible thing to do when using `highlight`.
>
> But if that is the case, you don't want "-r" (raw control chars for
> everything).  You would want to say "-R", I think.

Ahh thanks, that makes sense. I will update this for v2 tomorrow.