From: Alex Riesen <raa.lkml@gmail.com>
Date: Wed, 18 Jan 2012 14:25:54 GMT
Subject: Re: [PATCH] i18n: disable i18n for shell scripts if NO_GETTEXT defined
Message-ID: <CALxABCYXWxp=wVahbPjt9V4n5P7EQnqFFT3S5Dc7Co-P9BGJFQ@mail.gmail.com>
In-Reply-To: <7vfwfervt9.fsf@alter.siamese.dyndns.org>

On Tue, Jan 17, 2012 at 20:08, Junio C Hamano <gitster@pobox.com> wrote:
> Alex Riesen <raa.lkml@gmail.com> writes:
> Thanks for spotting. I agree that we should honor NO_GETTEXT here.
>
> But the result of the patch looks almost unreadable. could we restructure
> the script like this instead?
>
>        # Decide what to do...
>        GIT_INTERNAL_GETTEXT_SH_SCHEME=fallthrough
>        if test -n "@@NO_GETTEXT@@$GIT_INTERNAL_GETTEXT_TEST_FALLBACKS"
>        then

Oh, it is much nicer indeed. I shall redo the patch as soon as I get off
this crappy winxp computer.