From: Quint Guvernator <quintus.public@gmail.com>
Date: Wed, 12 Mar 2014 16:46:32 GMT
Subject: Re: [PATCH] general style: replaces memcmp() with starts_with()
Message-ID: <CALs4jVFpr=YVAagJSEkAJ6qGJmYWNdu4ZXXvMYQRd0KYQXcVQA@mail.gmail.com>
In-Reply-To: <5320818C.8070200@web.de>

2014-03-12 11:47 GMT-04:00 Jens Lehmann <Jens.Lehmann@web.de>:
> I think this hunk should be dropped as the memcmp() here doesn't mean
> "starts with" but "is identical" (due to the "ce_namelen(ce) == 11" in
> the line above).

There is an issue with negation in this patch. I've submitted a new
one [1] to the mailing list. The subject line of the new patch is
"[PATCH] general style: replaces memcmp() with proper starts_with()".

Let me know if you still think the hunk should be dropped there.

[1]: http://thread.gmane.org/gmane.comp.version-control.git/243940