From: Antti Halttunen <antti.halttunen@iki.fi>
Date: Thu, 07 Apr 2016 06:44:13 GMT
Subject: Re: bug: nested submodules get an absolute gitdir path
Message-ID: <CALoo-5XQtLsiEneqLdJyi8Wa5pTX_Kz8f7C1H6ir2=J2ZLAyLg@mail.gmail.com>
In-Reply-To: <xmqqmvp6zsos.fsf@gitster.mtv.corp.google.com>

On Wed, Apr 6, 2016 at 6:02 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Antti Halttunen <Antti.Halttunen@iki.fi> writes:
>
>> Starting with git v2.7.0,
>>
>> submodules two levels deep get a .git contents of:
>>  gitdir: /absolute/path/name
>
> I think that this is $gmane/290491
>
> http://thread.gmane.org/gmane.comp.version-control.git/290491
>
> and queued as sb/submodule-helper-clone-regression-fix topic,
> currently included on the 'pu' branch.  Can you try it and see if it
> fixes your issue?

it does, thanks.

> Thanks.
>
>>
>> This breaks repos that are moved or copied:
>>
>> fatal: Not a git repository:
>> /tmp/tmp.gIyxKWIC26/repo/.git/modules/sub/modules/sub
>> fatal: 'git status --porcelain' failed in submodule sub
>>
>> The script https://gitlab.com/snippets/17301 reproduces the issue.
>>
>> git bisect points to commit ee8838d1.
>>
>> thanks,

-- 
antti