From: D. Ben Knoble <ben.knoble@gmail.com>
Date: Mon, 10 Aug 2026 12:52:51 GMT
Subject: Re: [PATCH v2 3/4] completion: complete 'git history --update-refs' values
Message-ID: <CALnO6CDZURfK3HFQF_LYrSz0KWtamUguVWK3-cnVUCeA+oVBHQ@mail.gmail.com>
In-Reply-To: <20260806-history_autocompletion-v2-3-7e60f52a1c20@kernel.org>

On Thu, Aug 6, 2026 at 4:37 PM Vincent Mailhol <mailhol@kernel.org> wrote:
>
> The "--update-refs" option accepts either "branches" or "head".
> Complete these values.
>
> Although the synopsis only documents the:
>
>   --update-refs=<value>
>
> form, parse-options also accepts the value as a separate argument:
>
>   --update-refs <value>
>
> Support both forms to follow the parser.
>
> Signed-off-by: Vincent Mailhol <mailhol@kernel.org>
> ---
> Changes in v2:
>
>   - New patch.
> ---
>  contrib/completion/git-completion.bash | 5 +++++
>  t/t9902-completion.sh                  | 6 +++++-
>  2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index fe5223b8ec..6f1ba96763 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2181,6 +2181,11 @@ _git_history ()
>                                 ;;
>                         esac
>                         ;;
> +               --update-refs,*|*,--update-refs=*)
> +                       __gitcomp "branches head" "" \
> +                               "${cur##--update-refs=}"
> +                       return
> +                       ;;

Contrary to my comments on 2/4, this seems like a reasonable place for
--update-refs, since that applies to all current git-history commands.
If that ever changes, well… we'll deal with it then I suppose.

>                 *,--*)
>                         __gitcomp_builtin "history_$subcommand"
>                         return
[snip]


-- 
D. Ben Knoble