From: D. Ben Knoble <ben.knoble@gmail.com>
Date: Wed, 04 Jun 2025 21:36:06 GMT
Subject: Re: [PATCH v4 3/3] diff --no-index: support limiting by pathspec
Message-ID: <CALnO6CDUVpn-G20sFJviwjXX0xfjkG=HiUAMnWw96JCX+qyqgw@mail.gmail.com>
In-Reply-To: <04ea6073-16fe-43b6-919a-08187de030ba@intel.com>

On Wed, Jun 4, 2025 at 5:05 PM Jacob Keller <jacob.e.keller@intel.com> wrote:
>
>
>
> On 6/4/2025 1:19 PM, Junio C Hamano wrote:
> > Jacob Keller <jacob.e.keller@intel.com> writes:
> >
> >> Would you like a v5 with an updated commit message?
> >
> > What we had was already plenty readable to me, but if you think you
> > can improve it further, I do not mind waiting for another round of
> > update.
> >
> > Thanks.
>
> I'm fine with it as-is. I think the minor nits from Ben aren't worth a
> re-roll since there is no functional change, but wanted to confirm my
> opinion :)
>
> Thanks,
> Jake

Fine by me as well, thanks.

-- 
D. Ben Knoble