From: D. Ben Knoble <ben.knoble@gmail.com>
Date: Mon, 11 Aug 2025 21:05:43 GMT
Subject: Re: [PATCH v2] git-jump: make `diff` work with filenames containing spaces
Message-ID: <CALnO6CChgchH-KPyNwwy9zf41c_2miqza4rWS3NxzpZFcJmEsg@mail.gmail.com>
In-Reply-To: <4e2e2bea-c8e5-4343-9e70-a2bd139eb242@gmail.com>

On Mon, Aug 11, 2025 at 9:15 AM Phillip Wood <phillip.wood123@gmail.com> wrote:
>
> Hi Greg
>
> On 11/08/2025 12:55, Greg Hurrell via GitGitGadget wrote:
> > From: Greg Hurrell <greg.hurrell@datadoghq.com>
> > [...]
> > 1. For file "foo", Git will emit "foo".
> > 2. For file "foo bar", Git will emit "foo bar\t".
> > 3. For file "foo\t", Git will emit "\"foo\t\"".
> > 4. For file "foo bar\t", Git will emit "\"foo bar\t\"".
> >
> > Before this commit, `git-jump` correctly handled only case "1".
> >
> > After this commit, `git-jump` correctly handles cases "1" and "2". In
> > reality, these are the only cases people are going to run into with any
> > regularity, and the other two are rare edge cases, which probably aren't
> > worth the effort to support unless somebody actually complains about
> > them.
>
> Thanks for updating the commit message, I agree it's probably not worth
> worrying about cases 3 & 4 unless someone complains
>
> Thanks
>
> Phillip

Agreed, and fine by me (since we have a strict improvement).