From: D. Ben Knoble <ben.knoble@gmail.com>
Date: Mon, 19 Jan 2026 15:44:46 GMT
Subject: Re: What's cooking in git.git (Jan 2026, #05)
Message-ID: <CALnO6CC3WTBjaLR7yAr-w5eaqzyd2qF5MAyfV2wQY3+TDEbEsw@mail.gmail.com>
In-Reply-To: <CAHTeOx8z4bG2OmPCc+8pCHBVeUWPmxgaSqz=jHL+H=VRHx=KAA@mail.gmail.com>

On Sun, Jan 18, 2026 at 8:43 AM Yee Cheng Chin <ychin.macvim@gmail.com> wrote:
>
> > * yc/histogram-hunk-shift-fix (2025-12-06) 1 commit
> > - xdiff: re-diff shifted change groups when using histogram algorithm
> >
> > The final clean-up phase of the diff output could turn the result of
> > histogram diff algorithm suboptimal, which has been corrected.
> >
> > Will discard. Has been waiting for further comments for too long.
> > source:<pull.2120.git.git.1765054287938.gitgitgadget@gmail.com>
>
> Hi, I'm the author for this patch. I'm still pretty new to Git
> contribution, but what kind of comments are you looking for when
> deciding on a patch? I noticed that my patch didn't receive any
> comments, but it was essentially a bug fix for an occasional
> suboptimal histogram diff result. I would imagine most people would
> not have much to say given that it was not a new feature or introduced
> any breaking changes.

I just gave it another read and, while I can't comment on the xdiff
source changes, I find the proposed log message and test cases clear
(and demonstrate clear benefit).

I also appreciated the analysis of occurrence, which to me suggests
the performance cost is negligible.

Thanks.

-- 
D. Ben Knoble