From: D. Ben Knoble Date: Sat, 07 Nov 2026 19:49:53 GMT Subject: Re: [RFC PATCH 0/2] Support --verbose in git history Message-ID: In-Reply-To: <20261107193020.583215-1-jelle@vdwaa.nl> On Sat, Nov 7, 2026 at 2:36 PM Jelle van der Waa wrote: > > The new git history subcommands like reword do not support showing the > full git diff when editing the git commit message. This RFC adds support > for git history reword behave similiar to git commit --amend --verbose > except I choose to leave out support the "commit.verbose" configuration > option. Just as a first thought, while it is nice to keep the interfaces consistent with each other, I wonder if we want to reserve a different meaning for "verbose" in the context of git-history? For example, I've sometimes wished git-history would show the rewritten commits after execution: commit abc => def … Anyway, my point is, there's a lot of possible meanings for "verbose", so maybe we could use "--commit-verbose" (blech), "--diff-in-editor", or some other thing that smarter folks than I will come up with which clearly signals what we're about? > Other git history subcommands like split, squash and fixup could also > support --verbose under some circumstances (without --no-edit for fixup > or only with --reedit-message for fixup) > > I would be happy to work start with landing support for --verbose for > git history reword, ideally with it also supporting the "commit.verbose" > configuration option. Further patches could then add support for other > subcommands where it makes sense. > > Jelle van der Waa (2): > history: drop redundant strbuf_stripspace() > history: add --verbose option for reword > > Documentation/git-history.adoc | 11 +++- > builtin/history.c | 61 ++++++++++++++++++--- > t/t3451-history-reword.sh | 97 ++++++++++++++++++++++++++++++++++ > 3 files changed, 160 insertions(+), 9 deletions(-) > > -- > 2.56.0 Thanks for an interesting idea. -- D. Ben Knoble