From: D. Ben Knoble <ben.knoble@gmail.com>
Date: Sat, 26 Sep 2026 12:07:50 GMT
Subject: Re: [PATCH v2 3/4] t: test failed "stash apply --index"
Message-ID: <CALnO6CAwN=Xx5NUqNg8KZ9gf9Nn+nuSP6Yn3YnxyX5w8HqhkcQ@mail.gmail.com>
In-Reply-To: <b4023f5d-efba-487e-b273-a4283c50a774@gmail.com>

On Sat, Sep 26, 2026 at 5:53 AM Phillip Wood <phillip.wood123@gmail.com> wrote:
>
> On 25/09/2026 16:45, Phillip Wood wrote:
> >
> > I think that sounds reasonable, we can delete the index lines from the
> > patch output with sed to make it easier to compare them.
>
> I just opened the test file and realized it has a diff_cmp() function to
> compare diffs ignoring the index lines
>
> Thanks
>
> Phillip

Doh!

On the other hand, I don't think we need it. Those lines are showing
blob IDs, which would be stable in our case (fixed hash algorithm over
fixed contents), and we don't make the test dependent on the actual
IDs?

-- 
D. Ben Knoble