From: D. Ben Knoble <ben.knoble@gmail.com>
Date: Thu, 20 Aug 2026 11:50:58 GMT
Subject: Re: [PATCH v3 3/3] core: convert build-time USE_NSEC into runtime core.useNanosec
Message-ID: <CALnO6CAa0HKsKoytzfXvEmps4NLtx5qFkP9B4PZzW_Rfun+CNQ@mail.gmail.com>
In-Reply-To: <aoaPn0gaHIa9Utwu@pks.im>

On Thu, Aug 20, 2026 at 1:24 AM Patrick Steinhardt <ps@pks.im> wrote:
>
> That'd be quite welcome indeed. The less ifdeffery the bettery. :)

Agreed!

> On Wed, Aug 19, 2026 at 09:09:59AM -0400, D. Ben Knoble wrote:
> > On Wed, Aug 19, 2026 at 4:24 AM Patrick Steinhardt <ps@pks.im> wrote:
> > > There's one more site in "builtin/update-index.c" where we mention
> > > USE_NSEC that wasn't updated as part of this patch.
> >
> > Oh, did I miss one? The only spot I saw in builtin/update-index.c that
> > mentions USE_NSEC is a comment that I'm sure patch 3 updated. Maybe
> > you were thinking of that, or maybe you know of something I left out?
> > (That is, locally on this branch, "git grep USE_NSEC" returns one hit
> > in Documentation/RelNotes/2.5.0.adoc.)
>
> Oh, I guess I just missed it because I already trimmed context of this
> mail. Never mind then.
>
> Patrick

No worries, I appreciate the careful read!

-- 
D. Ben Knoble