From: D. Ben Knoble <ben.knoble@gmail.com>
Date: Sat, 15 Nov 2025 16:59:08 GMT
Subject: Re: [PATCH v4 01/10] doc: define unambiguous type mappings across C and Rust
Message-ID: <CALnO6CA-6waRpkqzLxR+f2yzwfhmf_jvbtEZC7FAFN9NLkqkXg@mail.gmail.com>
In-Reply-To: <xmqqpl9jfdso.fsf@gitster.g>

On Sat, Nov 15, 2025 at 11:42 AM Junio C Hamano <gitster@pobox.com> wrote:
>
> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
>
> >> This was discussed briefly in replies to v2’s 2/10, where
> >> Ezekiel said that DEVELOPER=1 warned about sign issues whether
> >> char was compared to int or unsigned. [From mobile I cannot
> >> reliably paste the message ID or link and preserve a plain-text
> >> email, apologies for the oblique reference.]
> >
> > Err... sorry, but I don't see how this comment relates to my
> > email. puzzled! ;)
>
> Me neither, but I suspect it may mostly use of non-word "signless"
> that is the issue.  It is understandable for the -Wsign-compare
> warning (especially given that it very often complains about
> perfectly good pieces of code) to complain when you compare a "char"
> with a signed integer, saying "on a platform where 'char' is
> unsigned, you would be comparing signed and unsigned values with
> this expression", and at the same time complain when you compare a
> "char" with an unsigned integer, saying "on a platform where 'char'
> is signed...".

Agreed, and I suspect this is roughly the implementation.

My point was that Ezekiel seemed to justify (?) the use of "signless"
by pointing to those warnings (I personally am on the fence for how to
treat the combination of facts, but it seems useful to consider that
char is not easily comparable with integers of various signedness).

-- 
D. Ben Knoble