From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Fri, 09 Dec 2011 07:56:49 GMT
Subject: Re: [PATCH 1/6] t3040 (subprojects-basic): modernize style
Message-ID: <CALkWK0nbp465915ysrBXi46mur1dutBDtPNjwW=RdyPV03crzg@mail.gmail.com>
In-Reply-To: <20111208163448.GA2394@elie.hsd1.il.comcast.net>

Hi,

Jonathan Nieder wrote:
> Ramkumar Ramachandra wrote:
>
>> Put the opening quote starting each test on the same line as the
>> test_expect_* invocation.  While at it:
>
> I suspect the above description, while it does describe your patch,
> does not describe the _reason_ that the patch exists or that someone
> would want to apply it.  Isn't it something more like:
> [...]

Right, fixed.

> I didn't read over the patch again.  Has it changed since v1?

No.  I refrained from making other style changes and/ or combining tests.

-- Ram