From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Wed, 26 Sep 2012 10:03:18 GMT
Subject: Re: [PATCH] mergetool--lib: Allow custom commands to override built-ins
Message-ID: <CALkWK0naJt840LfMNBM7EtdyLE5nmJeAsxG-Wttj8c84O5X7jA@mail.gmail.com>
In-Reply-To: <1348559291-71739-1-git-send-email-davvid@gmail.com>

Hi David,

David Aguilar wrote:
>  diff_cmd () {
> -       merge_tool_cmd="$(get_merge_tool_cmd "$1")"
> -       if test -z "$merge_tool_cmd"
> -       then
> -               status=1
> -               break
> -       fi
> -       ( eval $merge_tool_cmd )
> -       status=$?
> +       status=1
>         return $status
>  }

Nit: Why not return 1, instead of setting $status and returning it?

Ram