From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Sat, 22 Sep 2012 04:54:15 GMT
Subject: Re: [PATCH] t/test-lib.sh: do not trust $SHELL
Message-ID: <CALkWK0nTWQ3g75fN5wQLwgeW986vAzGdXajSGCY5SdpK8W=0aA@mail.gmail.com>
In-Reply-To: <7vwqzm3bhf.fsf@alter.siamese.dyndns.org>

Hi again,

On Sat, Sep 22, 2012 at 10:22 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Ramkumar Ramachandra <artagnon@gmail.com> writes:
>
>> Junio C Hamano wrote:
>>> The reference to ${SHELL-/bin/sh} in the test need to be updated to
>>> SHELL_PATH as Peff suggested in the other subthread.
>>
>> For that, the entire block needs to be moved down to come after `.
>> GIT_BUILD_DIR="$TEST_DIRECTORY"/..`.  Is this okay?
>
> Have you tested it with --tee (or valgrind) and does that work?

Yes, it works.

Ram