From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Thu, 24 Apr 2014 22:48:55 GMT
Subject: Re: [PATCH v7 03/12] revert/cherry-pick: add --quiet option
Message-ID: <CALkWK0nETYdWpTYrNGE+au-b=jAXKy3FX6YOGo5s=v_UbnYtPA@mail.gmail.com>
In-Reply-To: <1398307491-21314-4-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras wrote:
> @@ -635,9 +637,10 @@ static int do_pick_commit(struct commit *commit, struct replay_opts *opts)
>         }
>
>         if (opts->skip_empty && is_index_unchanged() == 1) {
> -               warning(_("skipping %s... %s"),
> -                       find_unique_abbrev(commit->object.sha1, DEFAULT_ABBREV),
> -                       msg.subject);
> +               if (!opts->quiet)
> +                       warning(_("skipping %s... %s"),
> +                               find_unique_abbrev(commit->object.sha1, DEFAULT_ABBREV),
> +                               msg.subject);

Personally, I don't see much value in inventing a new option for
suppressing one message.