From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Sat, 29 Sep 2012 15:07:33 GMT
Subject: Re: [PATCH] submodule: make 'show' an alias for 'summary'
Message-ID: <CALkWK0nCahg7165_JuJSj7u0UfYRGZgFjJ6O-o=HCwdsPwU-xg@mail.gmail.com>
In-Reply-To: <50670A94.2070504@web.de>

Hi Jens,

Jens Lehmann wrote:
> Am 29.09.2012 15:43, schrieb Ramkumar Ramachandra:
>> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
>> ---
>>  Like 'git remote show', 'git stash show'.
>
> I understand the analogy to "git stash show" (as that also displays
> a diff similar to what " git submodule summary" does). But "git
> remote show" just displays a list of configured remotes, which is
> something different. And the other command with a "show" option is
> "git notes show", which causes it to display a note. So I think we
> are pretty inconsistent here and I see no advantage of adding such
> an alias for "git submodule summary". What am I missing?

I used submodules for the first time, and expected 'git submodule
show' to work.  It may not be 100% consistent with the other commands,
but I think the 'summary' is a good match.  Either way, I don't feel
strongly about the patch, so feel free to drop it if you think it's
inappropriate.

Ram