From: Ramkumar Ramachandra Date: Thu, 28 Jul 2011 17:00:10 GMT Subject: Re: [PATCH 00/18] Sequencer for inclusion v4 Message-ID: In-Reply-To: <1311871951-3497-1-git-send-email-artagnon@gmail.com> Hi again, Ramkumar Ramachandra writes: > There were more style nits pointed out in v3: I learnt my lesson and > ran checkpatch.pl this time.  Apart these minor stylistic changes, the > other changes are: > 1. Minor improvements to commit messages. > 2. Tests now cleanup first, so one failing test doesn't take > everything else down. > 3. A rebase that moves "revert: Propogate errors upwards from > do_pick_commit" to the end of the series.  A big thanks to Jonathan > for performing the rebase for me. And one more significant change: 4. read_populate_todo, read_populate_opts and dependent functions were moved to the "revert: Introduce --continue to continue the operation" patch, eliminating the need for the ugly MAYBE_UNUSED. -- Ram