From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Tue, 15 Nov 2011 09:00:56 GMT
Subject: Re: [PATCH 1/5] sequencer: factor code out of revert builtin
Message-ID: <CALkWK0mtmRYyFosQNJixhheUmHpRjWc4A5zPQ6AaBfmw4H4eLQ@mail.gmail.com>
In-Reply-To: <7vvcqnmxeu.fsf@alter.siamese.dyndns.org>

Hi Junio,

Junio C Hamano writes:
> [...]
> With that observation, it would probably make more sense if "foo.c"
> included the headers in the following order:
>
>  - git-compat-util.h (or the prominent ones like "cache.h" that is known
>   to include it at the beginning);
>  - Anything the declarations in "foo.h" depends on;
>  - "foo.h" itself; and finally
>  - Other headers that "foo.c" implementation needs.
>
> That way, people who want to use "foo.h" can guess what needs to be
> included before using "foo.h" a lot more easily.

That's a good rule-of-thumb.  Thanks :)

-- Ram