From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Wed, 13 Jul 2011 10:27:56 GMT
Subject: Re: [PATCH 2/3] doc/fast-import: document feature import-marks-if-exists
Message-ID: <CALkWK0mkiVVAWpq2WMFZuSks4rJhrYA07Z0XyTFZUzxxmnUa-w@mail.gmail.com>
In-Reply-To: <1310483428-29833-3-git-send-email-divanorama@gmail.com>

Hi Dmitry,

In addition to Junio's comments, I have a few things to add:

Dmitry Ivankov writes:
> fast-import parameter --import-marks-if-exists was introduced in

It's a command-line option, not a parameter.

> commit dded4.. --import-marks can be set via a "feature" command in

Please more SHA-1 hex characters while abbreviating, and write a
little more information about the commit:
dded4f1 (fast-import: Introduce --import-marks-if-exists, 2011-01-15)

> a fast-import stream and --import-marks-if-exists has support for
> such specification too, for free.
>
> Document "feature import-marks-if-exists=<file>" command and add a
> minimalistic test for it.

Perhaps you can make it clearer that this feature was available back
in dded4f1, and was supposed to have been documented then?

Thanks for working on this.  I'm to blame for not documenting/ testing
the feature in the original patch.

-- Ram