From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Sun, 24 Jul 2011 10:23:24 GMT
Subject: Re: [PATCH 01/18] advice: Introduce error_resolve_conflict
Message-ID: <CALkWK0mfVXTb+p_73YpxY-hhTCN-XbR9jz7iDTKK+uKiE5prkQ@mail.gmail.com>
In-Reply-To: <20110722223555.GB19620@sigill.intra.peff.net>

Hi Phil and Jeff,

Jeff King writes:
> On Thu, Jul 21, 2011 at 11:35:44AM -0400, Phil Hord wrote:
>> In either case, the comma after "Please" is wrong.  (There are other
>> messages in the git code which make this same mistake, but there are
>> more which use "Please <imperative-verb>..." correctly.)
>
> Still, I think I find it more readable without the comma, and better
> still if every spot were converted to "hint: ". This question has come
> up once or twice before, too, so I don't know that a patch removing the
> commas would be out of line.

Ah, I was wondering about this too.  Even if a patch that goes around
removing commas or "Please, " in the entire codebase isn't desirable,
I can make the change in this series.

Thanks.

-- Ram