From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Sat, 22 Jun 2013 07:36:34 GMT
Subject: Re: [PATCH 05/16] remote: remove dead code in read_branches_file()
Message-ID: <CALkWK0mYmhnOL-F+StuKWSeQ48EsQSAnS0_6u-B8KKq+RrOW5A@mail.gmail.com>
In-Reply-To: <7v1u7vkslz.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:
> As far as I can tell, that valid-remote-nick was done in df93e33c
> (Validate nicknames of remote branches to prohibit confusing ones,
> 2008-02-15), and back in that version, the codepath and the feature
> that wants to see a slash and do magical things, which is described
> by this comment you are removing:

It's a bad hack, in my opinion.  When I say git fetch ../foomery, it
should catch the pattern at transport_get() and not even attempt to
look up a remote in the first place.  I will attempt to clean this up
soon.

> So it appears that back then (and througout to today), nobody uses
> that "partial URL" feature which is specific (and was a rather nice
> invention/legacy by Cogito) to .git/branches file.

It's quite a cute feature, even if a bit magical.

> Reminds me of the strategy to deprecate functionality in X (cf.
> http://lwn.net/Articles/536520/) ;-)

Leaving dead code around to confuse readers? :\