From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Wed, 13 Jul 2011 06:14:09 GMT
Subject: Re: [PATCH 03/17] revert: Don't check lone argument in get_encoding
Message-ID: <CALkWK0mWFvDFdOhQuZK-E-_78YGdXve42NX=Zj6S4BTDu+pTzA@mail.gmail.com>
In-Reply-To: <20110712165949.GB13578@elie>

Hi Jonathan,

Jonathan Nieder writes:
> Ramkumar Ramachandra wrote:
>> The get_encoding function has only one callsite, and its caller makes
>> sure that a NULL argument isn't passed.  Don't unnecessarily double
>> check the same argument in get_encoding.
>
> Such a double-check is not a huge maintenance burden, is it?  As I
> mentioned at [1], I am guessing the actual motivation is (1) to avoid
> having to pass "commit" around and (2) to avoid burdening translators
> with a message that will never be shown.
>
> Would it be possible to clarify the commit message so it is no longer
> necessary to guess?

I should have done this earlier.  Thanks for being so patient :)

revert: Don't check lone argument in get_encoding

The get_encoding function has only one callsite, and its caller makes
sure that a NULL argument isn't passed.  Don't unnecessarily double
check the same argument in get_encoding.  As a result, avoid passing
"commit" around, and remove a string marked for translation that will
never be shown.

-- Ram