From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Thu, 08 Dec 2011 13:04:39 GMT
Subject: Re: [PATCH 15/15] t3040 (subprojects-basic): modernize style
Message-ID: <CALkWK0mScWsQanBu=cq-qiC3Ls=bYnjA4eiY4mUFs+kr9_OHdQ@mail.gmail.com>
In-Reply-To: <20111207222126.GF2911@elie.hsd1.il.comcast.net>

Hi,

Jonathan Nieder wrote:
> It would be easier to read if each preimage test assertion were next to
> the corresponding postimage test assertion.  Does "git diff --patience"
> do better?

No, unfortunately.

> If cleaning up the style anyway, I would write this as
> [...]
> But leaving it alone like you did is probably better. ;-)

Exercising restraint.  Otherwise, I'm tempted to fix every little nit
in every test I'm touching in the series :P

>> -test_expect_success 'check if fsck ignores the subprojects' \
>> -    'git fsck --full'
>> +test_expect_success 'check if fsck ignores the subprojects' '
>> +     git fsck --full
>> +'
>
> Does this test imply that one of the subprojects is broken somehow?

Hm, you're right- the test doesn't seem to make any sense.  I'll deal
with it in another patch (unrelated to this series).

Thanks.

-- Ram