From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Tue, 19 Jul 2011 08:52:45 GMT
Subject: Re: [RFC PATCH] config: Introduce functions to write non-standard file
Message-ID: <CALkWK0mSWxkGZOrZor0+bZNd4V-OrU+6-0n_Lo+F8qCyd=72vA@mail.gmail.com>
In-Reply-To: <7vr55n9mc3.fsf@alter.siamese.dyndns.org>

Hi Junio,

Junio C Hamano writes:
> Ramkumar Ramachandra <artagnon@gmail.com> writes:
[...]
> Yuck, what an ugly hack when you are so close.  Why not restructure the
> code in such a way that the updated config-set-multivar and set-in-file
> share the code better?  If the former takes a hardcoded logic to decide
> which file to write to while the latter takes the filename to write to as
> its argument, wouldn't it be a lot more natural to make config-set-multivar
> call set-in-file after computing what filename parameter to pass?

Ugh, sorry. Fixed now.

-- Ram