From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Wed, 20 Mar 2013 18:12:35 GMT
Subject: Re: [PATCH 1/6] remote.c: simplify a bit of code using git_config_string()
Message-ID: <CALkWK0mKKRmVdvvLmrqCPdPQoeYxWaFcuixyonnDM6o8Nt7ppg@mail.gmail.com>
In-Reply-To: <20130320180707.GH3655@google.com>

Jonathan Nieder wrote:
> Ramkumar Ramachandra wrote:
>
>> --- a/remote.c
>> +++ b/remote.c
>> @@ -356,9 +356,7 @@ static int handle_config(const char *key, const char *value, void *cb)
>>                       return 0;
>>               branch = make_branch(name, subkey - name);
>>               if (!strcmp(subkey, ".remote")) {
>> -                     if (!value)
>> -                             return config_error_nonbool(key);
>> -                     branch->remote_name = xstrdup(value);
>> +                     git_config_string(&branch->remote_name, key, value);
>
> Shouldn't this say
>
>                         if (git_config_string(&branch->remote_name, key, value))
>                                 return -1;
>
> or something?

Yes, and so should the instances in [5/6] and [6/6].  Thanks for catching it.