From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Fri, 03 Jan 2014 18:58:31 GMT
Subject: Re: [PATCH 3/4] completion: fix branch.autosetup(merge|rebase)
Message-ID: <CALkWK0mGJ2V9V=KzuaAraNX-edEVBEpp-9DcAaBF-dZCqp6bsw@mail.gmail.com>
In-Reply-To: <xmqq1u0pnf7b.fsf@gitster.dls.corp.google.com>

Junio C Hamano wrote:
> You seem to be calling it "incorrect" to give the same degree of
> completion for a branch the user named "autosetupmerge" as another
> branch "topic", but I think it is incorrect not to, so I cannot tell
> if we are agreeing or disagreeing.

No, what's incorrect is providing completions for

  $ git config branch.autosetupmerge.<TAB>

when no branch called "autosetupmerge" exists. The purpose of the hunk
(which I now removed) was to prevent such completions, but it has the
side-effect of also preventing a legitimate completion in the case
when the user really has a branch named "autosetupmerge".

What is your take on the issue?