From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Fri, 09 Dec 2011 06:12:35 GMT
Subject: Re: [PATCH 2/5] revert: make commit subjects in insn sheet optional
Message-ID: <CALkWK0mEE_v_Frm-N0ErsUY4vJ8rX1Fi1Wx_70a72j9EY+mmCA@mail.gmail.com>
In-Reply-To: <CALkWK0nkPB5WptJ9nSkSOif5_0R_f39Dg_HR3Rmg02hG_4Q1Tg@mail.gmail.com>

Hi,

Ramkumar Ramachandra wrote:
> 1. Implement the strscpn() using two strchrnul() calls.
> 2. Drop this patch and use strbuf to replace the fixed-size buffer.
>
> I think I'll go with the second option.  What do you think?
> [...]


Er, I have an 'eol' which I'm not using.  Making sure that 'eol' is
valid is good enough to avoid unexpected failures: if strchrnul() is
able to find a '\n', strcspn() should have no trouble finding either a
' ' or '\n' (whichever comes first).

Sorry for the nonsense.

-- Ram