From: Ramkumar Ramachandra Date: Tue, 23 Apr 2013 16:38:01 GMT Subject: Re: [PATCH 2/7] rebase -i: don't error out if $state_dir already exists Message-ID: In-Reply-To: <7vd2tljjcx.fsf@alter.siamese.dyndns.org> Junio C Hamano wrote: > So I do not see why this change could be an improvement. I would > understand it if some future changes may have already created the > state dir from a separate codepath (which may be an indication of a > poor design of integrating that separate codepath, but that is a > different matter) and mkdir needs to be turned into "mkdir -p" here, > but I do not think removal of "|| die" is warranted even in such a > case. Yeah, it's [7/7] creating a $state_dir/autostash before anything else can happen. Okay, if I put the "|| die" back in, does it require any more justification?