From: Ramkumar Ramachandra Date: Sat, 20 Jul 2013 07:55:09 GMT Subject: Re: [PATCH] Fix compilation on OS X. Message-ID: In-Reply-To: <1374306567-16640-1-git-send-email-tsunanet@gmail.com> Benoit Sigoure wrote: > diff --git a/compat/unsetenv.c b/compat/unsetenv.c > index 4ea1856..addf3dc 100644 > --- a/compat/unsetenv.c > +++ b/compat/unsetenv.c > @@ -1,5 +1,10 @@ > #include "../git-compat-util.h" > > +#ifdef __APPLE__ > +// On OS X libc headers don't define this symbol. > +extern char **environ; > +#endif > + Shouldn't this go into git-compat-util.h, since there may be other files depending on this variable?