From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Tue, 18 Sep 2012 07:17:42 GMT
Subject: Re: [PATCH] t/test-lib: print pretty msg when git isn't built
Message-ID: <CALkWK0kbeLtU-5_9QnmQKS1yO02SvCW3ERvami9bmCa0Vym8oQ@mail.gmail.com>
In-Reply-To: <7v627bq0gx.fsf@alter.siamese.dyndns.org>

Hi,

Junio C Hamano wrote:
> Ramkumar Ramachandra <artagnon@gmail.com> writes:
>
>> Hi Junio,
>>
>> Junio C Hamano wrote:
>>> Is this a sufficient replacement for what you removed from 0000?
>>> Can the BUILD-OPTIONS file exist when your build of git failed?
>>
>> Oops, I didn't realize that BUILD-OPTIONS would be written when the
>> build fails.  How about something like this instead:
>
> Yeah, but why change it so much?  Wouldn't writing
>
>         "$GIT_BUILD_DIR/git" >/dev/null
>         if test $? != 1
>         then
>                 : You haven't built git!
>         fi
>
> just like the original in 0000 be sufficient??

Because that emits an ugly
./test-lib.sh: 54: /home/artagnon/src/git/t/../git: not found

Ram