From: Ramkumar Ramachandra Date: Thu, 10 Apr 2014 21:44:21 GMT Subject: Re: [PATCH v2 8/9] sha1_name: simplify track finding Message-ID: In-Reply-To: <1397156686-31349-9-git-send-email-felipe.contreras@gmail.com> Felipe Contreras wrote: > It's more efficient to check for the braces first. Why is it more efficient? So you can error out quickly in the case of a malformed string? I'm personally not thrilled about this change.