From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Wed, 16 Nov 2011 08:51:46 GMT
Subject: Re: [PATCH 0/3] avoiding unintended consequences of git_path() usage
Message-ID: <CALkWK0kPM1S9ELTWL1SiGjFN1e3NK2V-q4ixqM77aUMuDPxdqg@mail.gmail.com>
In-Reply-To: <20111116075955.GB13706@elie.hsd1.il.comcast.net>

Hi Jonathan,

Jonathan Nieder wrote:
> Ramkumar Ramachandra wrote:
>> Junio C Hamano wrote:
>
>>> Or perhaps http://thread.gmane.org/gmane.comp.version-control.git/184963/focus=185436
>>
>> I noticed that sha1_to_hex() also operates like this.  The
>> resolve_ref() function is really important, but using the same
>> technique for these tiny functions is probably an overkill
>
> I don't follow.  Do you mean that not being confusing is overkill,
> because the function is small that no one will bother to look up the
> right semantics?  Wait, that sentence didn't come out the way I
> wanted. ;-)

I meant overkill in terms of the work required and code churn.
Ofcourse, I'd have been more than happy to see it being implemented-
and you've actually done it now! :) Nguyễn has a more fancy solution,
though I'm quite happy with this as it is.

Finally, for all the times I've fumbled in git_path() usage:
Liked-by: Ramkumar Ramachandra <artagnon@gmail.com>

Thanks for working on this.

-- Ram