From: Ramkumar Ramachandra Date: Fri, 12 Aug 2011 03:17:20 GMT Subject: Re: [PATCH 0/6] Towards a generalized sequencer Message-ID: In-Reply-To: <20110812023323.GA672@elie.gateway.2wire.net> Hi, [+CC: Johannes Schindelin] Jonathan Nieder writes: > Isn't it still the same built-in cherry-pick code, originally by Dscho > and improved over time by others?  The filename is irrelevant. True, but we can't have "This implements the builtins revert and cherry-pick." in sequencer.c, no? > If you want to add your and Christian's names to reflect > multiple-cherry-pick and the restructuring, I guess that would be ok. > Better yet, if you want to remove Dscho's name to encourage people to > look at the commit log and get a richer story, just ask Dscho. I thought about this a bit. I'm completely against the former option -- I merely meant it as a "I'm confused; help!" rather than a suggestion; adding contributors' names to the list is a bad idea. I looked at some copyright notices in other files and re-evaluated: it's a cute historical note to have. Unless Johannes wants to remove it now, I'd like to put the following in sequencer.c: /* * Used to implement the builtins revert and cherry-pick. * * Copyright (c) 2007 Johannes E. Schindelin * * Based on git-revert.sh, which is * * Copyright (c) 2005 Linus Torvalds * Copyright (c) 2005 Junio C Hamano */ Sorry about the confusion. Feel free to suggest a better "title line". Thanks. -- Ram