From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Sun, 05 Jan 2014 10:06:21 GMT
Subject: Re: [PATCH v3 2/4] completion: introduce __gitcomp_nl_append ()
Message-ID: <CALkWK0=rrcTFdpymGB5QJhdLhYvm4FLMGurqugbCGvAdDKVhqA@mail.gmail.com>
In-Reply-To: <xmqq38l4n6h9.fsf@gitster.dls.corp.google.com>

Junio C Hamano wrote:
> Is it because going this route and doing it at such a low level
> would make zsh completion (which I have no clue about ;-)
> unnecessarily complex?

The zsh completion only cares to override __gitcomp_nl () and
__gitcomp_nl_append (), without bothering to re-implement the
lower-level functions; so it's no problem at all. I wrote mine out by
thinking of a non-intrusive direct translation, while your version
focuses on eliminating duplication. I don't have a strong preference
either way, so I will resubmit with your version.