From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Fri, 21 Sep 2012 19:31:32 GMT
Subject: Re: How do I run tests under Valgrind?
Message-ID: <CALkWK0=nMxNfmAaBTmXeADQubTayC_2_ut5Nq3QXba9yfQr9yA@mail.gmail.com>
In-Reply-To: <20120917182957.GF1179@sigill.intra.peff.net>

Hi Peff,

I was able to reproduce the problem on all my machines, and I consider
this very disturbing.  However, I was successfully able to corner the
issue. I have an overtly long $PATH that's not getting split properly
by `IFS=:` in one corner case -- in other words, this shell script
fails to execute properly when called with `--tee` (just set a really
long $PATH and try):


    case "$GIT_TEST_TEE_STARTED, $* " in
    done,*)
    	# do not redirect again
    	;;    #!/bin/sh

    case "$GIT_TEST_TEE_STARTED, $* " in
    done,*)
    	# do not redirect again
    	;;
    *' --tee '*|*' --va'*)
    	mkdir -p test-results
    	BASE=test-results/$(basename "$0" .sh)
    	(GIT_TEST_TEE_STARTED=done ${SHELL-sh} "$0" "$@" 2>&1;
    	 echo $? > $BASE.exit) | tee $BASE.out
    	test "$(cat $BASE.exit)" = 0
    	exit
    	;;
    esac

    OLDIFS=$IFS
    IFS=:
    for path in $PATH
    do
        ls "$path"/git-* 2> /dev/null |
        while read file
        do
    	echo $file
        done
    done

I'm still trying to figure out what exactly the problem is, and how to patch it.

Thanks.

Ram