From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Wed, 27 Jul 2011 09:47:03 GMT
Subject: Re: [PATCH 06/18] revert: Propogate errors upwards from do_pick_commit
Message-ID: <CALkWK0=dFzVdqi3CJMBzkQO4WGe5-U1eQXwpVNZd33nLXD3+Qw@mail.gmail.com>
In-Reply-To: <20110727043908.GD18470@elie>

Hi Jonathan,

Jonathan Nieder writes:
> Patch 5 is good.  I still find patch 6 unconvincing, since it makes
> the behavior inconsistent (there are still many ways for
> revert_or_cherry_pick to exit() or die()), does not help with anything
> that comes later, and it is more of a burden than most of the rest of
> the patches to review (since one has to look at context not contained
> in the diff to see if it is safe to continue running after an error
> that previously would exit).

:sigh:

> In the long term, I really do want this
> change, though.  If you'd like, I can rebase to put it at the end of
> the series (which shouldn't be hard).

That would be awesome -- the rebase won't be easy at all though.

-- Ram