From: Ramkumar Ramachandra Date: Tue, 18 Jun 2013 07:03:22 GMT Subject: Re: [PATCH 1/2] sha1_name: stop hard-coding 40-character hex checks Message-ID: In-Reply-To: Phil Hord wrote: > I share your disdain for the bare '40's in the code. But I think this > code is less clear than the previous version with the magic number. Please read the cover-letter: I was just toying around to see if this was a good idea, and Junio points out that it's not.