From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Wed, 29 May 2013 12:33:25 GMT
Subject: Re: [PATCH v2 7/8] revert/cherry-pick: add --quiet option
Message-ID: <CALkWK0=QyznWZt4sJCok9OZxjrdjtMTtpStA8LHdCCbn0Oi6TA@mail.gmail.com>
In-Reply-To: <1369799788-24803-8-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras wrote:
>         if (opts->skip_empty && is_index_unchanged() == 1) {
> -               warning(_("skipping %s... %s"),
> -                       find_unique_abbrev(commit->object.sha1, DEFAULT_ABBREV),
> -                       msg.subject);
> +               if (!opts->quiet)
> +                       warning(_("skipping %s... %s"),
> +                               find_unique_abbrev(commit->object.sha1, DEFAULT_ABBREV),
> +                               msg.subject);
>                 goto leave;
>         }

All this trouble just to suppress the "skipping ..." message.  Do you
see anything else --quiet can be used to suppress?