From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Thu, 25 Apr 2013 18:25:50 GMT
Subject: Re: [PATCH 5/9] remote-hg: use hashlib instead of hg sha1 util
Message-ID: <CALkWK0=Q2KZPioYD21pYLzruBnFh_cpFLh_rDj7QDa3bOaCO6g@mail.gmail.com>
In-Reply-To: <1366888849-19607-6-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras wrote:
> To be in sync with remote-bzr.

Huh?  Why do you have to be in sync with remote-bzr?  Are you sharing
code between remote-hg and remote-bzr?

> @@ -830,7 +831,7 @@ def main(args):
>
>      if alias[4:] == url:
>          is_tmp = True
> -        alias = util.sha1(alias).hexdigest()
> +        alias = hashlib.sha1(alias).hexdigest()

Did you eve bother justifying this change with a line in the commit
message?  How is the new form different from the old form?