From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Thu, 04 Aug 2011 10:02:16 GMT
Subject: Re: [PATCH 17/18] revert: Introduce --continue to continue the operation
Message-ID: <CALkWK0=19kc3tT3+kMDdmc-eXJwPhGwy6=dwJ4HS65UUA33FiQ@mail.gmail.com>
In-Reply-To: <201108020451.36617.chriscool@tuxfamily.org>

Hi Christian,

Christian Couder writes:
> Ooops, sorry I mean like this:
>
>        for (i = 1; *p; i++) {
>                struct commit *commit = parse_insn_line(p, opts);
>                if (!commit)
>                        return error(_("Could not parse line %d."), i);
>                next = commit_list_append(commit, next);
>                p = strchrnul(p, '\n');
>                if (*p)
>                        p++;
>        }

Thanks for catching this bug, and showing me how to handle it correctly! :)
While fixing this, I took the opportunity to incorporate all your
other suggestions in my new series.  Will post the new series shortly.

[It broke my new series, but this was definitely worth fixing]

-- Ram